secretary
/
waitonbot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clarified interaction listener expiration behaviour

This commit is contained in:
Jacob Henry 2019-03-03 20:12:07 -05:00
parent 2d4c6141a7
commit d63ed10798
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hooks.py
View File

@ -155,7 +155,8 @@ class InteractionListener(AbsHook):
Guarantees Interaction, Message, User, and Conversation Guarantees Interaction, Message, User, and Conversation
For fields that don't have a value of their own (such as buttons), For fields that don't have a value of their own (such as buttons),
one can provide a mapping of action_ids to values. one can provide a mapping of action_ids to values.
In either case, the value is fed as a parameter to the callback In either case, the value is fed as a parameter to the callback.
The hook dies after successfully invoking callback.
""" """
def __init__(self, def __init__(self,
@ -164,7 +165,7 @@ class InteractionListener(AbsHook):
# The action_id -> value mapping. Value fed to callback # The action_id -> value mapping. Value fed to callback
message_ts: str, # Which message contains the block we care about message_ts: str, # Which message contains the block we care about
lifetime: float, # How long to keep listening lifetime: float, # How long to keep listening
on_death: Optional[Callable[[], None]] # Function to call on death. For instance, if you want to delete the message on_expire: Optional[Callable[[], None]] # Function to call on death by timeout. For instance, if you want to delete the message, or edit it to say "timed out"
): ):
super().__init__(True) super().__init__(True)
self.callback = callback self.callback = callback
@ -172,7 +173,7 @@ class InteractionListener(AbsHook):
self.message_ts = message_ts self.message_ts = message_ts
self.lifetime = lifetime self.lifetime = lifetime
self.start_time = time() self.start_time = time()
self.on_death = on_death self.on_death = on_expire
self.dead = False self.dead = False
def try_apply(self, event: slack_util.Event) -> Optional[MsgAction]: def try_apply(self, event: slack_util.Event) -> Optional[MsgAction]:
@ -202,9 +203,11 @@ class InteractionListener(AbsHook):
# If the value is still none, we have an issue! # If the value is still none, we have an issue!
if value is None: if value is None:
raise ValueError("Couldn't find an appropriate value for interaction {}".format(event.interaction)) print("Couldn't find an appropriate value for interaction {}".format(event.interaction))
return None
# Call the callback # Call the callback
self.dead = True
return self.callback(event, value) return self.callback(event, value)